From: Tim Blechmann Subject: Re: snd_mask_min Date: Tue, 26 Jul 2011 09:16:31 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from lo.gmane.org (lo.gmane.org [80.91.229.12]) by alsa0.perex.cz (Postfix) with ESMTP id 23B5F103877 for ; Tue, 26 Jul 2011 09:16:43 +0200 (CEST) Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Qlbsg-0004PE-RF for alsa-devel@alsa-project.org; Tue, 26 Jul 2011 09:16:42 +0200 Received: from 85-127-248-33.dynamic.xdsl-line.inode.at ([85.127.248.33]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 26 Jul 2011 09:16:42 +0200 Received: from tim by 85-127-248-33.dynamic.xdsl-line.inode.at with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 26 Jul 2011 09:16:42 +0200 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org >> it uses an inline function snd_mask_min, which is declared in >> sound/pcm_params.h, but this file is not included by sound/pcm.h, where it >> is defined. including it manually, causes a huge number of errors. it would >> be very helpful, if pcm.h would be self-contained. > > Well, pcm_params.h is just an additional header that aren't used by > most drivers, so it doesn't make much sense to include such > unconditionally from the common pcm.h. then wouldn't it make sense to move those parts from pcm.h that depend on pcm_params.h to that header? especially the params_* family? at the moment pcm.h is not self-contained, which is not really what i expect from a header ... tim