From: Andreas Schwab Subject: Re: [PATCH 18/22][RFC] Unionfs: Superblock operations Date: Mon, 04 Sep 2006 10:24:56 +0200 Message-ID: References: <20060901013512.GA5788@fsl.cs.sunysb.edu> <20060901015851.GS5788@fsl.cs.sunysb.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Josef Sipek , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, hch@infradead.org, akpm@osdl.org, viro@ftp.linux.org.uk Return-path: Received: from ns1.suse.de ([195.135.220.2]:58811 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S1750779AbWIDIZI (ORCPT ); Mon, 4 Sep 2006 04:25:08 -0400 To: Jan Engelhardt In-Reply-To: (Jan Engelhardt's message of "Mon, 4 Sep 2006 09:46:59 +0200 (MEST)") Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Jan Engelhardt writes: >>+/* final actions when unmounting a file system */ >>+static void unionfs_put_super(struct super_block *sb) >>+{ >>+ int bindex, bstart, bend; >>+ struct unionfs_sb_info *spd; >>+ >>+ if ((spd =3D stopd(sb))) { > > Sugg.: > > if((spd =3D stopd(sb)) =3D=3D NULL) > return; Better: spd =3D stopd(sb); if (!spd) return; Andreas. --=20 Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany PGP key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4= ED5 "And now for something completely different." --=20 VGER BF report: H 0 - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html