Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J1QuY-0006Zg-Fw for qemu-devel@nongnu.org; Sun, 09 Dec 2007 13:29:54 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J1QuX-0006YQ-1n for qemu-devel@nongnu.org; Sun, 09 Dec 2007 13:29:54 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J1QuW-0006YJ-Jc for qemu-devel@nongnu.org; Sun, 09 Dec 2007 13:29:52 -0500 Received: from mx2.suse.de ([195.135.220.15]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1J1QuW-0007sG-8P for qemu-devel@nongnu.org; Sun, 09 Dec 2007 13:29:52 -0500 Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id BA4F62C9E2 for ; Sun, 9 Dec 2007 19:29:49 +0100 (CET) From: Andreas Schwab Subject: Re: [Qemu-devel] [PATCH] Allow setting the vendor_id string with x86's -cpu option References: <20071125132334.GA9555@karma.qumranet.com> <20071209030244.GC12436@networkno.de> <20071209092721.GA2858@karma.qumranet.com> <200712091136.36900.paul@codesourcery.com> <20071209135201.GA5113@karma.qumranet.com> Date: Sun, 09 Dec 2007 19:29:49 +0100 In-Reply-To: <20071209135201.GA5113@karma.qumranet.com> (Dan Kenigsberg's message of "Sun\, 9 Dec 2007 15\:52\:01 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Dan Kenigsberg writes: > + x86_cpu_def->vendor1 =3D val[0] + (val[1] << 8) > + + (val[2] << 16) + (val[3] << 24)= ; > + x86_cpu_def->vendor2 =3D val[4] + (val[5] << 8) > + + (val[6] << 16) + (val[7] << 24)= ; > + x86_cpu_def->vendor3 =3D val[8] + (val[9] << 8) > + + (val[10] << 16) + (val[11] << 2= 4); That will do the wrong thing with the sign bit. Andreas. --=20 Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany PGP key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED= 5 "And now for something completely different."