From: Andreas Schwab Subject: Re: [PATCH 9/12: eCryptfs] Inode operations Date: Fri, 04 Nov 2005 01:24:07 +0100 Message-ID: References: <20051103033220.GD2772@sshock.rn.byu.edu> <20051103035411.GI3005@sshock.rn.byu.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Phillip Hellewell , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, mike@halcrow.us, mhalcrow@us.ibm.com, mcthomps@us.ibm.com, yoder1@us.ibm.com Return-path: Received: from mx1.suse.de ([195.135.220.2]:31469 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S1030567AbVKDAYL (ORCPT ); Thu, 3 Nov 2005 19:24:11 -0500 To: James Morris In-Reply-To: (James Morris's message of "Thu, 3 Nov 2005 18:51:25 -0500 (EST)") Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org James Morris writes: > On Wed, 2 Nov 2005, Phillip Hellewell wrote: > >> +static int grow_file(struct dentry *ecryptfs_dentry, struct file *l= ower_file, >> + struct inode *inode, struct inode *lower_inode) >> +{ >> + int rc =3D 0; >> + struct file fake_file; >> + memset(&fake_file, 0, sizeof(fake_file)); > > > You don't need these initializations, bss is always initialized to ze= ro=20 > in this environment. Automatic variables are not related to the bss segment. Andreas. --=20 Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany Key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html