Content-Type: multipart/mixed; boundary="===============2123205928105782211==" MIME-Version: 1.0 From: Valentin Schneider To: kbuild-all@lists.01.org Subject: Re: [PATCH] sched/debug: fix noderef.cocci warnings Date: Wed, 12 Aug 2020 19:52:07 +0100 Message-ID: In-Reply-To: <20200812175958.GA94389@b1d876c4bf9f> List-Id: --===============2123205928105782211== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 12/08/20 18:59, kernel test robot wrote: > From: kernel test robot > > kernel/sched/debug.c:272:30-36: ERROR: application of sizeof to pointer > > sizeof when applied to a pointer typed expression gives the size of > the pointer > > Generated by: scripts/coccinelle/misc/noderef.cocci > > CC: Valentin Schneider > Signed-off-by: kernel test robot > --- > > url: https://github.com/0day-ci/linux/commits/Valentin-Schneider/sched= -Instrument-sched-domain-flags/20200812-205638 > base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 949bc= b8135a96a6923e676646bd29cbe69e8350f > > debug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/kernel/sched/debug.c > +++ b/kernel/sched/debug.c > @@ -269,7 +269,7 @@ static int sd_ctl_doflags(struct ctl_tab > return 0; > } > > - tmp =3D kcalloc(data_size + 1, sizeof(tmp), GFP_KERNEL); > + tmp =3D kcalloc(data_size + 1, sizeof(*tmp), GFP_KERNEL); Praised be coccinelle for rubbing in my face that I can't write code; also I'm not even checking if the allocation succeeded which is clearly daft, even if this is debug stuff. I'll blame the heat and try to move on... > for_each_set_bit(idx, &flags, __SD_FLAG_CNT) { > char *name =3D sd_flag_debug[idx].name; > --===============2123205928105782211==--