Received: from eggs.gnu.org ([2001:4830:134:3::10]:37702) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VI7Ue-0001sJ-W9 for qemu-devel@nongnu.org; Fri, 06 Sep 2013 21:39:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VI7UZ-0003GJ-11 for qemu-devel@nongnu.org; Fri, 06 Sep 2013 21:39:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59462) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VI7UY-0003G8-PS for qemu-devel@nongnu.org; Fri, 06 Sep 2013 21:39:14 -0400 From: Bandan Das References: <1378419871-31895-1-git-send-email-bsd@redhat.com> <1378419871-31895-3-git-send-email-bsd@redhat.com> <1378452326.13048.7.camel@nilsson.home.kraxel.org> Date: Fri, 06 Sep 2013 21:39:03 -0400 In-Reply-To: <1378452326.13048.7.camel@nilsson.home.kraxel.org> (Gerd Hoffmann's message of "Fri, 06 Sep 2013 09:25:26 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2 2/3] hda-codec: make mixemu selectable at runtime List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Paolo Bonzini , "Vassili Karpov (malc)" , qemu-devel@nongnu.org, Jan Kiszka , Markus Armbruster Gerd Hoffmann writes: >> --- a/hw/audio/hda-codec.c >> +++ b/hw/audio/hda-codec.c >> @@ -118,7 +118,20 @@ static void hda_codec_parse_fmt(uint32_t format, struct audsettings *as) >> #define QEMU_HDA_AMP_NONE (0) >> #define QEMU_HDA_AMP_STEPS 0x4a >> >> +#ifdef CONFIG_MIXEMU >> +#define PARAM mixemu >> +#define HDA_MIXER >> #include "hda-codec-common.h" >> +#else >> +/* keep the compiler quiet */ >> +static const desc_codec output_mixemu; >> +static const desc_codec duplex_mixemu; >> +static const desc_codec micro_mixemu; > > Needed? The *_mixemu variants are not referenced without CONFIG_MIXEMU Indeed, they are not needed anymore. Thanks for the catch. I will fix this in a follow-up post. >> +#endif >> + >> +#define PARAM nomixemu > > #undefine HDA_MIXER > This is not needed as I already undef this in the header file. >> +#include "hda-codec-common.h" >> + > > cheers, > Gerd