From: Dan Magenheimer Subject: Re: [patch] final header fixes Date: Thu, 24 Mar 2005 20:40:25 +0000 (UTC) Message-ID: References: <200503231601.02096.hollisb@us.ibm.com> <65c3741c137c25c43f5c11baeccca15a@cl.cam.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: xen-devel-admin@lists.sourceforge.net Errors-To: xen-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: xen-devel@lists.sourceforge.net List-Id: xen-devel@lists.xenproject.org Sorry for the delay in comment... I was traveling and am a bit behind on email. This second patch looks good to me, though I would prefer to change to '#include ' from 'struct xen_regs;' as xen_regs is #define'd to pt_regs on ia64 and the explicit use of struct xen_regs in a header could cause header ordering problems later. Will that work for ppc? Dan ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click