From: Bernhard Kohl Subject: [PATCH] KVM: IOAPIC: Do not check polarity Date: Fri, 13 Mar 2009 10:53:02 +0000 (UTC) Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit To: kvm@vger.kernel.org Return-path: Received: from main.gmane.org ([80.91.229.2]:52736 "EHLO ciao.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756435AbZCMKxU (ORCPT ); Fri, 13 Mar 2009 06:53:20 -0400 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1Li50w-0006Wk-DR for kvm@vger.kernel.org; Fri, 13 Mar 2009 10:53:18 +0000 Received: from 192.100.130.229 ([192.100.130.229]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 13 Mar 2009 10:53:18 +0000 Received: from bernhard.kohl by 192.100.130.229 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 13 Mar 2009 10:53:18 +0000 Sender: kvm-owner@vger.kernel.org List-ID: NSN's proprietary OS DMX heavily depends on a correct BIOS MP table. >From there it also gets the information for initialization of PCI devices. We defined the polarity and trigger mode as for standard PCI devices "low level". The OS programs the ioapic the same way. Nothing else in QEMU's and KVM's IRQ, PIC, IOAPIC and LAPIC code cares about interrupt polarity. The "level" is always used as a logical value. So we must not change the level here. If we do so, PCI low level interrupts are not fired if the guest raises the interrupt (level=1), but first if it is reset again (level=0). This can result in infinite waiting for a single interupt. For example the DMX guest waits for the link up interupt of the E1000 ethernet device before enabling the TX and RX interupts of this device. E1000 emulation sets level=1, no interrupt is fired, deadlock. This does not happen if we use the -no-kvm-irqchip option. This means that qemu's ioapic does not care about the polarity and kvm's ioapic shouldn't do either. Signed-off-by: Bernhard Kohl --- virt/kvm/ioapic.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c index 1eddae9..4deb8e1 100644 --- a/virt/kvm/ioapic.c +++ b/virt/kvm/ioapic.c @@ -180,7 +180,6 @@ int kvm_ioapic_set_irq(struct kvm_ioapic *ioapic, int irq, int level) if (irq >= 0 && irq < IOAPIC_NUM_PINS) { entry = ioapic->redirtbl[irq]; - level ^= entry.fields.polarity; if (!level) ioapic->irr &= ~mask; else { -- 1.6.0.6