From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: [patch 01/27] fs: cleanup files_lock Date: Fri, 24 Apr 2009 22:35:10 -0700 Message-ID: References: <20090425012020.457460929@suse.de> <20090425012209.061706790@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Al Viro , Alan Cox To: npiggin@suse.de Return-path: Received: from out01.mta.xmission.com ([166.70.13.231]:51682 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751857AbZDYFfT (ORCPT ); Sat, 25 Apr 2009 01:35:19 -0400 In-Reply-To: <20090425012209.061706790@suse.de> (npiggin@suse.de's message of "Sat\, 25 Apr 2009 11\:20\:21 +1000") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: npiggin@suse.de writes: > Lock tty_files with tty_mutex, provide helpers to manipulate the per-sb > files list, and unexport the files_lock spinlock. This conflicts a bit with some of my ongoing work, which is generalizing the file list to make it more useful and makes the tty case much less of a special case. Do you know if the performance improvement would be anywhere near as good if file_list and file_list_lock becoming per inode? Do you have any idea what the performance improvement with changing the file_list_lock is? > Index: linux-2.6/fs/open.c > =================================================================== > --- linux-2.6.orig/fs/open.c > +++ linux-2.6/fs/open.c > @@ -828,7 +828,7 @@ static struct file *__dentry_open(struct > f->f_path.mnt = mnt; > f->f_pos = 0; > f->f_op = fops_get(inode->i_fop); > - file_move(f, &inode->i_sb->s_files); > + file_sb_list_add(f, inode->i_sb); You can make this just: if (!special_file(inode->i_mode)) file_add(f, &inode->i_files); And save yourself a lot of complexity. Eric