From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: [RFC, PATCH 16/24] i386 Vmi io header Date: Wed, 15 Mar 2006 14:17:32 -0700 Message-ID: References: <200603131811.k2DIBS8j005741@zach-dev.vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <200603131811.k2DIBS8j005741@zach-dev.vmware.com> (Zachary Amsden's message of "Mon, 13 Mar 2006 10:11:28 -0800") Sender: linux-kernel-owner@vger.kernel.org Cc: Linus Torvalds , Linux Kernel Mailing List , Virtualization Mailing List , Xen-devel , Andrew Morton , Dan Hecht , Dan Arai , Anne Holler , Pratap Subrahmanyam , Christopher Li , Joshua LeVasseur , Chris Wright , Rik Van Riel , Jyothy Reddy , Jack Lo , Kip Macy , Jan Beulich , Ky Srinivasan , Wim Coekaerts , Leendert van Doorn , Zachary Amsden List-Id: xen-devel@lists.xenproject.org Zachary Amsden writes: > Move I/O instruction building to the sub-arch layer. Some very crafty > but esoteric macros are used here to get optimized native instructions > for port I/O in Linux be writing raw instruction strings. Adding a > wrapper layer here is fairly easy, and makes the full range of I/O > instructions available to the VMI interface. > > Also, slowing down I/O is not a useful operation in a VM, so there > is a VMI call specifically to allow making it a NOP. I could find > no place where SLOW_IO_BY_JUMPING is still used, and consider it > obsoleted. Even on older 386 systems, the I/O delay approximation > by touching the extra page register is likely to better. This sounds like a prime candidate for the alternate instruction interfaces and I don't see that being used here. Eric