From: ebiederm@xmission.com (Eric W. Biederman) Subject: [PATCH 15/13] sysfs: Protect sysfs_refresh_inode with inode mutex. Date: Wed, 04 Nov 2009 04:05:08 -0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Kay Sievers , Greg KH , linux-kernel@vger.kernel.org, Tejun Heo , Cornelia Huck , linux-fsdevel@vger.kernel.org, Eric Dumazet , Benjamin LaHaise , Serge Hallyn To: Greg Kroah-Hartman Return-path: Received: from out02.mta.xmission.com ([166.70.13.232]:37159 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752332AbZKDMFH (ORCPT ); Wed, 4 Nov 2009 07:05:07 -0500 In-Reply-To: (Eric W. Biederman's message of "Tue\, 03 Nov 2009 03\:53\:56 -0800") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: In general everything that writes to vfs inodes holds the inode mutex, so hold the inode mutex over sysfs_refresh_inode. The sysfs data structures don't need this but it looks like the vfs might. Signed-off-by: Eric W. Biederman --- fs/sysfs/inode.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/fs/sysfs/inode.c b/fs/sysfs/inode.c index e2595a7..ad549f5 100644 --- a/fs/sysfs/inode.c +++ b/fs/sysfs/inode.c @@ -240,9 +240,11 @@ int sysfs_getattr(struct vfsmount *mnt, struct dentry *dentry, struct kstat *sta struct sysfs_dirent *sd = dentry->d_fsdata; struct inode *inode = dentry->d_inode; + mutex_lock(&inode->i_mutex); mutex_lock(&sysfs_mutex); sysfs_refresh_inode(sd, inode); mutex_unlock(&sysfs_mutex); + mutex_unlock(&inode->i_mutex); generic_fillattr(inode, stat); return 0; @@ -353,9 +355,11 @@ int sysfs_permission(struct inode *inode, int mask) { struct sysfs_dirent *sd = inode->i_private; + mutex_lock(&inode->i_mutex); mutex_lock(&sysfs_mutex); sysfs_refresh_inode(sd, inode); mutex_unlock(&sysfs_mutex); + mutex_unlock(&inode->i_mutex); return generic_permission(inode, mask, NULL); } -- 1.6.5.2.143.g8cc62