From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: [PATCH 01/13] sysfs: Update sysfs_setxattr so it updates secdata under the sysfs_mutex Date: Tue, 03 Nov 2009 14:13:52 -0800 Message-ID: References: <1257249429-12384-1-git-send-email-ebiederm@xmission.com> <20091103134823.GB31981@us.ibm.com> <20091103213129.GA13555@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Greg Kroah-Hartman , Kay Sievers , Greg KH , linux-kernel@vger.kernel.org, Tejun Heo , Cornelia Huck , linux-fsdevel@vger.kernel.org, Eric Dumazet , Benjamin LaHaise , "Eric W. Biederman" To: "Serge E. Hallyn" Return-path: Received: from out02.mta.xmission.com ([166.70.13.232]:45633 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755234AbZKCWOB (ORCPT ); Tue, 3 Nov 2009 17:14:01 -0500 In-Reply-To: <20091103213129.GA13555@us.ibm.com> (Serge E. Hallyn's message of "Tue\, 3 Nov 2009 15\:31\:29 -0600") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: "Serge E. Hallyn" writes: > > Gah, sorry. No prob. > Acked-by: Serge Hallyn > > (as an aside, I can't see any reason to not just return if strncmp(name, > XATTR_SECURITY_PREFIX,) above to avoid a level of indent and needless gotos) Sounds like it is worth a patch. For now I'm concentrating on getting this patchset merged, and extraneous cleanups have a way of dragging the process out beyond what time I have to give. Eric