From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: [PATCH 15/13] sysfs: Protect sysfs_refresh_inode with inode mutex. Date: Sat, 07 Nov 2009 23:04:03 -0800 Message-ID: References: <4AF4DAEC.5010503@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Greg Kroah-Hartman , Kay Sievers , Greg KH , linux-kernel@vger.kernel.org, Cornelia Huck , linux-fsdevel@vger.kernel.org, Eric Dumazet , Benjamin LaHaise , Serge Hallyn To: Tejun Heo Return-path: Received: from out02.mta.xmission.com ([166.70.13.232]:36064 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751185AbZKHHED (ORCPT ); Sun, 8 Nov 2009 02:04:03 -0500 In-Reply-To: <4AF4DAEC.5010503@kernel.org> (Tejun Heo's message of "Sat\, 07 Nov 2009 11\:26\:52 +0900") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Tejun Heo writes: > Eric W. Biederman wrote: >> In general everything that writes to vfs inodes holds the >> inode mutex, so hold the inode mutex over sysfs_refresh_inode. >> The sysfs data structures don't need this but it looks like the >> vfs might. >> >> Signed-off-by: Eric W. Biederman > > Acked-by: Tejun Heo > > Sidenote: Hmmm... Originally, sysfs completely depended on vfs locking > but with sysfs_dirent separation, the tree structure itself and some > attributes went under the protection of sysfs_mutex while leaving more > vfs oriented fields under vfs locking. This patchset makes sysfs > lazier so it can't depend on any vfs layer locking. I think you've > converted all necessary places while removing dependency on > dentry/inode from update operations but it might be a good idea to do > a audit pass over how fields are being protected now. You raised a good point. I took a quick second pass through. I did not see anything I have missed, and I did not change anything else on the vfs path. So at the very least I don't expect there are any locking related regressions. Eric