From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman) Subject: Re: [PATCH 06/14] sysfs: Rewrite sysfs_get_dentry Date: Wed, 01 Aug 2007 11:40:06 -0600 Message-ID: References: <46AF15F6.6010202@suse.de> <46AF1E57.3030209@suse.de> <20070731141613.GC13674@htj.dyndns.org> <46B05A1D.5000703@gmail.com> <46B0C0E6.5030008@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <46B0C0E6.5030008-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> (Tejun Heo's message of "Thu, 02 Aug 2007 02:20:38 +0900") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tejun Heo Cc: Greg KH , Greg KH , cornelia.huck-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org, stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org, satyam-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, Linux Containers , Dave Hansen List-Id: containers.vger.kernel.org Tejun Heo writes: > Hmmm... I think we can live with a bit of complexity in > sysfs_get_dentry(). It's very well localized and not even long. I have > been trying hard to untangle sysfs internals from vfs and have a bit of > resistance against going back. But, then again, if we can achieve > something better and simpler, why not? Right now my real challenge is untangling sysfs_move_dir. In the case of multiple mounts of the sysfs tree. My practical problem is that I need to hold a lock for the sysfs dirents and while that lock is held I need to call sysfs_get_dentry for the destination directory once for each superblock. It might be that some kind of reader-writer lock strategy is what I need to untangle this mess. Rather then making changing to i_mutex. All I know is at the moment it is taking a lot of code reading and brain storm to come of with something that is easy to maintain. Eric