From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: [PATCH 06/15] sysfs: Fix locking and factor out sysfs_sd_setattr Date: Fri, 20 Nov 2009 13:39:06 -0800 Message-ID: References: <1257665233-12468-6-git-send-email-ebiederm@xmission.com> <20091120201355.GA30590@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Greg Kroah-Hartman , Kay Sievers , linux-kernel@vger.kernel.org, Tejun Heo , Cornelia Huck , linux-fsdevel@vger.kernel.org, Eric Dumazet , Benjamin LaHaise , Serge Hallyn , "Eric W. Biederman" To: Greg KH Return-path: Received: from out02.mta.xmission.com ([166.70.13.232]:51388 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755929AbZKTVjP (ORCPT ); Fri, 20 Nov 2009 16:39:15 -0500 In-Reply-To: <20091120201355.GA30590@kroah.com> (Greg KH's message of "Fri\, 20 Nov 2009 12\:13\:55 -0800") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Greg KH writes: > On Sat, Nov 07, 2009 at 11:27:04PM -0800, Eric W. Biederman wrote: >> From: Eric W. Biederman >> >> Cleanly separate the work that is specific to setting the >> attributes of a sysfs_dirent from what is needed to update >> the attributes of a vfs inode. >> >> Additionally grab the sysfs_mutex to keep any nasties from >> surprising us when updating the sysfs_dirent. >> >> Acked-by: Tejun Heo >> Signed-off-by: Eric W. Biederman > > Due to the extended attr work for sysfs that went into Linus's tree > recently, this patch doesn't apply at all anymore. I will take a look. I'm scratching my about how that caused a problem because that patch came out of my tree originally, before the rest of these patches. So if anything I should have problems in the other direction. Eric