From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman) Subject: Re: [PATCH 2/4] sysfs: Implement sysfs manged shadow directory support. Date: Mon, 30 Jul 2007 21:24:03 -0600 Message-ID: References: <1182446577.8138.29.camel@localhost> <20070621211637.GB10583@suse.de> <20070622001328.GA14113@suse.de> <20070625212339.GA13398@kroah.com> <46A3B449.3090409@gmail.com> <20070722202508.GA18018@suse.de> <46A425F9.1030008@gmail.com> <46AD8E92.7080002@suse.de> <46ADDC7F.1090306@sw.ru> <46ADE24E.8020502@suse.de> <46ADEE35.8000109@sw.ru> <46ADF003.3010100@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: (Eric W. Biederman's message of "Mon, 30 Jul 2007 09:51:28 -0600") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tejun Heo Cc: Linux Containers , Greg KH , Greg KH , Dave Hansen List-Id: containers.vger.kernel.org Ugh. I need to step back and carefully define what I'm seeing but it looks like the current sysfs locking is wrong. I'm starting to find little inconsistencies all over the place such as: Which lock actually protects sd->s_children? - It isn't sysfs_mutex. (see sysfs_lookup) - It isn't inode->i_mutex (we only get it if we happen to have the inode in core) At first glance sysfs_assoc_lock looks just as bad. Eric