From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: [PATCH 13/13] sysfs: Factor out sysfs_rename from sysfs_rename_dir and sysfs_move_dir Date: Wed, 04 Nov 2009 14:23:50 -0800 Message-ID: References: <1257249429-12384-13-git-send-email-ebiederm@xmission.com> <20091104221957.GB21033@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Greg Kroah-Hartman , Kay Sievers , Greg KH , linux-kernel@vger.kernel.org, Tejun Heo , Cornelia Huck , linux-fsdevel@vger.kernel.org, Eric Dumazet , Benjamin LaHaise , "Eric W. Biederman" To: "Serge E. Hallyn" Return-path: In-Reply-To: <20091104221957.GB21033@us.ibm.com> (Serge E. Hallyn's message of "Wed\, 4 Nov 2009 16\:19\:57 -0600") Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org "Serge E. Hallyn" writes: > Quoting Eric W. Biederman (ebiederm@xmission.com): >> From: Eric W. Biederman >> >> These two functions do 90% of the same work and it doesn't significantly >> obfuscate the function to allow both the parent dir and the name to change >> at the same time. So merge them together to simplify maintenance, and >> increase testing. >> >> Acked-by: Tejun Heo >> Signed-off-by: Eric W. Biederman > > Based on just this patchset it seems sysfs_rename() could be static, > but since it isn't static I assume your later patchset will use it > outside fs/sysfs/dir.c? To implement sysfs_rename_link, but that is too much to digest/review/push all at once. I have a snapshot of my development tree up on kernel.org if you are interested. Eric