From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: [PATCH 01/20] sysfs: Implement sysfs_rename_link Date: Wed, 27 May 2009 18:51:47 -0700 Message-ID: References: <1242865694-2100-1-git-send-email-ebiederm@xmission.com> <20090528001418.GA2499@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Greg KH , Andrew Morton , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Tejun Heo , Cornelia Huck , linux-fsdevel@vger.kernel.org, Benjamin Thery , Daniel Lezcano , "Eric W. Biederman" To: Kay Sievers Return-path: Received: from out02.mta.xmission.com ([166.70.13.232]:52690 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759095AbZE1Bv4 (ORCPT ); Wed, 27 May 2009 21:51:56 -0400 In-Reply-To: (Kay Sievers's message of "Thu\, 28 May 2009 02\:30\:15 +0200") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Kay Sievers writes: > On Thu, May 28, 2009 at 02:14, Greg KH wrote: >> >> So, there's been a lot of talk in this thread. >> >> Eric, do you have an updated set of patches for me to try out? > > I think we should get a version of the patch in that removes all files > in a directory on cleanup, but warn if a subdirectory is still there. > James has a patch to fix the one issue we've seen so far with existing > child directories. > > After that, we should work on fixing the users that leave files > behind, and can possibly stop cleaning up files, if we want to. Agreed. We are not yet ready to only remove empty directories from sysfs. So fixing that problem with the current sysfs should be done in a separate patchset after the other fixes. I will look at putting that together. Eric