From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman) Subject: [PATCH 04/14] sysfs: Remove unnecessary variable found from sysfs_lookup Date: Tue, 31 Jul 2007 04:24:08 -0600 Message-ID: References: <1182446577.8138.29.camel@localhost> <20070722202508.GA18018@suse.de> <46A425F9.1030008@gmail.com> <46AD8E92.7080002@suse.de> <46ADDC7F.1090306@sw.ru> <46ADE24E.8020502@suse.de> <46ADEE35.8000109@sw.ru> <46ADF003.3010100@suse.de> <46AEAF79.6080404@suse.de> <46AEBA87.6000400@suse.de> <46AEEF75.2030101@suse.de> <46AEEFA6.4000901@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: (Eric W. Biederman's message of "Tue, 31 Jul 2007 04:22:56 -0600") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tejun Heo Cc: Linux Containers , Greg KH , Greg KH , Dave Hansen List-Id: containers.vger.kernel.org The subject says it all. Signed-off-by: Eric W. Biederman --- fs/sysfs/dir.c | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c index 834ed74..8430633 100644 --- a/fs/sysfs/dir.c +++ b/fs/sysfs/dir.c @@ -748,19 +748,16 @@ static struct dentry * sysfs_lookup(struct inode *dir, struct dentry *dentry, struct dentry *result = NULL; struct sysfs_dirent * sd; struct inode *inode; - int found = 0; mutex_lock(&sysfs_mutex); for (sd = parent_sd->s_children; sd; sd = sd->s_sibling) { if (sysfs_type(sd) && - !strcmp(sd->s_name, dentry->d_name.name)) { - found = 1; + !strcmp(sd->s_name, dentry->d_name.name)) break; - } } /* no such entry */ - if (!found) + if (!sd) goto out; /* attach dentry and inode */ -- 1.5.1.1.181.g2de0