From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: [PATCH 09/13] sysfs: Implement sysfs_getattr & sysfs_permission Date: Sat, 07 Nov 2009 22:04:07 -0800 Message-ID: References: <1257249429-12384-9-git-send-email-ebiederm@xmission.com> <4AF4D640.7030101@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Greg Kroah-Hartman , Kay Sievers , Greg KH , linux-kernel@vger.kernel.org, Cornelia Huck , linux-fsdevel@vger.kernel.org, Eric Dumazet , Benjamin LaHaise , "Eric W. Biederman" To: Tejun Heo Return-path: Received: from out01.mta.xmission.com ([166.70.13.231]:49298 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbZKHGEP (ORCPT ); Sun, 8 Nov 2009 01:04:15 -0500 In-Reply-To: <4AF4D640.7030101@kernel.org> (Tejun Heo's message of "Sat\, 07 Nov 2009 11\:06\:56 +0900") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Tejun Heo writes: > Eric W. Biederman wrote: >> diff --git a/fs/sysfs/symlink.c b/fs/sysfs/symlink.c >> index 1137418..c5eff49 100644 >> --- a/fs/sysfs/symlink.c >> +++ b/fs/sysfs/symlink.c >> @@ -214,6 +214,9 @@ const struct inode_operations sysfs_symlink_inode_operations = { >> .readlink = generic_readlink, >> .follow_link = sysfs_follow_link, >> .put_link = sysfs_put_link, >> + .setattr = sysfs_setattr, > > It would be nice either to separate addition of setattr to symlinks > into a separate patch or note it in the description. Good point note added. Eric