From: ebiederm@xmission.com (Eric W. Biederman) Subject: [PATCH 08/15] sysfs: Make sysfs_mount static once again. Date: Thu, 03 Jul 2008 18:14:36 -0700 Message-ID: References: <20080618170729.808539948@theryb.frec.bull.fr> <486A0751.9080602@gmail.com> <486AF4FA.8020805@gmail.com> <486B060C.7030607@gmail.com> <486C4515.1070007@gmail.com> <486CB051.5000507@fr.ibm.com> <486CF71F.5090405@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: (Eric W. Biederman's message of "Thu, 03 Jul 2008 18:13:05 -0700") Sender: netdev-owner@vger.kernel.org To: Greg Kroah-Hartman , Andrew Morton Cc: Tejun Heo , Daniel Lezcano , linux-kernel@vger.kernel.org, Al Viro , Linux Containers , Benjamin Thery , netdev@vger.kernel.org List-Id: containers.vger.kernel.org Accessing the internal sysfs_mount is error prone in the context of multiple super blocks, and nothing needs it. Not even the sysfs crash debugging patch (although it did in an earlier version). Signed-off-by: Eric W. Biederman --- fs/sysfs/mount.c | 2 +- fs/sysfs/sysfs.h | 1 - 2 files changed, 1 insertions(+), 2 deletions(-) diff --git a/fs/sysfs/mount.c b/fs/sysfs/mount.c index c812cc4..99974f0 100644 --- a/fs/sysfs/mount.c +++ b/fs/sysfs/mount.c @@ -22,7 +22,7 @@ /* Random magic number */ #define SYSFS_MAGIC 0x62656572 -struct vfsmount *sysfs_mount; +static struct vfsmount *sysfs_mount; struct super_block * sysfs_sb = NULL; struct kmem_cache *sysfs_dir_cachep; diff --git a/fs/sysfs/sysfs.h b/fs/sysfs/sysfs.h index 5ee5d0a..33b3c73 100644 --- a/fs/sysfs/sysfs.h +++ b/fs/sysfs/sysfs.h @@ -97,7 +97,6 @@ struct sysfs_super_info { extern struct sysfs_dirent sysfs_root; extern struct super_block *sysfs_sb; extern struct kmem_cache *sysfs_dir_cachep; -extern struct vfsmount *sysfs_mount; extern struct file_system_type sysfs_fs_type; void sysfs_grab_supers(void); -- 1.5.3.rc6.17.g1911