From: Detlev Zundel Date: Fri, 26 Mar 2010 10:30:27 +0100 Subject: [U-Boot] What's wrong with this code? In-Reply-To: <98831269592801@webmail103.yandex.ru> (Dennis Semakin's message of "Fri, 26 Mar 2010 11:40:01 +0300") References: <98831269592801@webmail103.yandex.ru> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Dennis, > Hello, > Months ago I had a problem with network on Colibri PXA320. A applied all patches from Marek's web > site http://openpxa.sourceforge.net/, but net didn't work at all in U-Boot and in Linux. > When I tried to read/write into/from ethernet chip I/O registers, that was mapped in the memory, system hung. > > See http://lists.infradead.org/pipermail/linux-arm-kernel/2010-February/009279.html > > Solution was prompted by Daniel Mack (Thanks Daniel). > > Add this code to lowlevel_init function in U-Boot: > //begin > ldr r0, =CKENA > ldr r1, [r0] > orr r1, r1, #(CKENA_4_NAND | CKENA_9_SMC) > str r1, [r0] > ldr r1, [r0] > //end > > After that network has worked in u-boot and in linux. > Also he said: "It did see this code, but it wasn't taken for upstream, for reasons I > cannot remember..." > > What's wrong with this code? Why don't you wrap this change into a patch and post it here[1] on the mailing list. If there are reasons not to merge it, the respective people will speak up. Also note in the commit message that this fixes a real bug for you and what hardware you tested it on. Cheers Detlev [1] http://www.denx.de/wiki/U-Boot/Patches -- If we knew what it was we were doing, we wouldn't call it research. -- Einstein -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de