From: Detlev Zundel Date: Wed, 22 Sep 2010 16:26:34 +0200 Subject: [U-Boot] [PATCH 3/5 v2] ppc4xx: Move gpio.h to ppc4xx-gpio.h since its ppc4xx specific In-Reply-To: <1284650032-14606-1-git-send-email-sr@denx.de> (Stefan Roese's message of "Thu, 16 Sep 2010 17:13:52 +0200") References: <1284650032-14606-1-git-send-email-sr@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefan, > Signed-off-by: Stefan Roese > --- > v2: > - Removed all non-PPC4xx related files. Sorry for this. > > arch/powerpc/cpu/ppc4xx/cpu_init.c | 2 +- > arch/powerpc/cpu/ppc4xx/gpio.c | 2 +- > arch/powerpc/include/asm/{gpio.h => ppc4xx-gpio.h} | 0 > board/amcc/acadia/memory.c | 2 +- > board/amcc/bamboo/bamboo.c | 2 +- > board/amcc/canyonlands/canyonlands.c | 2 +- > board/amcc/katmai/katmai.c | 2 +- > board/amcc/makalu/makalu.c | 2 +- > board/amcc/sequoia/sequoia.c | 2 +- > board/amcc/taihu/lcd.c | 2 +- > board/amcc/taihu/taihu.c | 2 +- > board/esd/pmc405de/pmc405de.c | 2 +- > board/gdsys/dlvision/dlvision.c | 2 +- > board/gdsys/intip/intip.c | 2 +- > board/korat/korat.c | 2 +- > board/lwmon5/lwmon5.c | 2 +- > board/mosaixtech/icon/icon.c | 2 +- > board/quad100hd/nand.c | 2 +- > board/quad100hd/quad100hd.c | 2 +- > board/t3corp/t3corp.c | 2 +- > board/zeus/update.c | 2 +- > board/zeus/zeus.c | 2 +- > post/board/lwmon5/watchdog.c | 2 +- > 23 files changed, 22 insertions(+), 22 deletions(-) > rename arch/powerpc/include/asm/{gpio.h => ppc4xx-gpio.h} (100%) Can't you rename the file "internally" so that users of the header still only include asm/gpio.h? Really at some point I want to see only such an include for users of the gpio system, so why introduce such a detail in all users now? I.e. why not have a gpio.h which does a conditional include of ppc4xx-gpio.h? Thanks Detlev -- Bacchus, n. A convenient deity invented by the ancients as an excuse for getting drunk. -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de