From: Detlev Zundel Date: Wed, 09 Sep 2009 13:54:39 +0200 Subject: [U-Boot] [PATCH 1/2] mpc52xx, mucmc52, uc101: config cleanup In-Reply-To: <4AA755CD.8050807@denx.de> (Heiko Schocher's message of "Wed, 09 Sep 2009 09:14:21 +0200") References: <4AA755CD.8050807@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Heiko, > - as this boards are similiar, collect common config option > in manroland-common.h > - add OF support > - update default environment > > Signed-off-by: Heiko Schocher > --- > board/mucmc52/mucmc52.c | 7 + > board/uc101/uc101.c | 7 + > include/configs/manroland-common.h | 336 ++++++++++++++++++++++++++++++++++++ > include/configs/mucmc52.h | 256 +-------------------------- > include/configs/uc101.h | 266 +--------------------------- > 5 files changed, 368 insertions(+), 504 deletions(-) > create mode 100644 include/configs/manroland-common.h [...] > + * High Level Configuration Options > + * (easy to change) > + */ > +#define CONFIG_MPC5xxx 1 /* This is an MPC5xxx CPU */ > +#define CONFIG_MPC5200 1 /* (more precisely an MPC5200 CPU) */ > + > +#define CONFIG_SYS_MPC5XXX_CLKIN 33000000 /* ... running at 33.000000MHz */ Are you sure that this is a good choice to put in a manufacturer common header file? Isn't the probability of this becoming incorrect nearly 100% for the next board from this manufacturer? I'd advise to keep CPU stuff in the individual board config files - maybe, if you really want, create a "manroland-mpc52xx-common.h". The rest of the common configs should be re-evaluated in the same spirit. Cheers Detlev -- LISP has jokingly been described as "the most intelligent way to misuse a computer". I think that description a great compliment because it transmits the full flavour of liberation: it has assisted a number of our most gifted fellow humans in thinking previously impossible thoughts. - Edsger W. Dijkstra -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de