Return-Path: Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lLyLq-00HB4C-6N for linux-um@lists.infradead.org; Tue, 16 Mar 2021 01:18:28 +0000 Received: by mail-pg1-x531.google.com with SMTP id 16so15112581pgo.13 for ; Mon, 15 Mar 2021 18:18:25 -0700 (PDT) Date: Tue, 16 Mar 2021 10:18:22 +0900 Message-ID: From: Hajime Tazaki Subject: Re: [RFC v8 08/20] um: lkl: memory handling In-Reply-To: <03c74a353c87994b61450ba8086f1ccda40b2ea8.camel@sipsolutions.net> References: <19d4990f2ef77ad595248183071da5e43149931c.1611103406.git.thehajime@gmail.com> <03c74a353c87994b61450ba8086f1ccda40b2ea8.camel@sipsolutions.net> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: johannes@sipsolutions.net Cc: linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, tavi.purdila@gmail.com, linux-kernel-library@freelists.org, linux-arch@vger.kernel.org, retrage01@gmail.com On Mon, 15 Mar 2021 01:53:01 +0900, Johannes Berg wrote: > > > > > > +#else > > + > > +#include > > + > > +extern void force_flush_all(void); > > > nit: no need for "extern" thanks, will fix this. > > +#define CONFIG_KERNEL_RAM_BASE_ADDRESS memory_start > > +#include > > + > > +#define __va_space (8*1024*1024) > > + > > +#ifndef __ASSEMBLY__ > > +#include > > Is that ? I think we should start including only with that > prefix. okay, will fix it. > > + > > +void *uml_kmalloc(int size, int flags) > > +{ > > + return kmalloc(size, flags); > > +} > > That could probably still be shared? This function is a stub of arch/um/kernel/mem.c, which LKL doesn't use for the build. Thus we defined here. Or are you suggesting to not stubbing this function, but extracting the function from mem.c ? > > +int set_memory_ro(unsigned long addr, int numpages) > > +{ > > + return -EOPNOTSUPP; > > +} > > + > > +int set_memory_rw(unsigned long addr, int numpages) > > +{ > > + return -EOPNOTSUPP; > > +} > > + > > +int set_memory_nx(unsigned long addr, int numpages) > > +{ > > + return -EOPNOTSUPP; > > +} > > + > > +int set_memory_x(unsigned long addr, int numpages) > > +{ > > + return -EOPNOTSUPP; > > +} > > UML for now no longer has these either. Ah, I see the changes. Will fix them. -- Hajime _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um