From: Andrew W Elble Date: Tue, 06 Oct 2015 15:33:41 -0400 Subject: [Cluster-devel] [GFS2 PATCH 06/15] GFS2: Prevent gl_delete work for re-used inodes In-Reply-To: <1092374767.41518211.1444158139643.JavaMail.zimbra@redhat.com> (Bob Peterson's message of "Tue, 6 Oct 2015 15:02:19 -0400") References: <1444059397-4705-1-git-send-email-rpeterso@redhat.com> <1444059397-4705-7-git-send-email-rpeterso@redhat.com> <1092374767.41518211.1444158139643.JavaMail.zimbra@redhat.com> Message-ID: List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Bob Peterson writes: > Hi Andrew, > > Actually, I've found a few bugs and problems with that last patch set > and revised my patches last week. I've also added the glock flag, but > used "x" rather than "-" because I'm not sure I like punctuation marks there, > but nothing else makes sense either. The other changes are for the other > thing you spotted (which I caught in testing). The proper way to do it > is to initialize the i_gl to ip->i_gl in the evict code, and not have the > if at all. That affects two of the patches: I was wondering about that. I'll get that changed. Thanks, Andy -- Andrew W. Elble aweits at discipline.rit.edu Infrastructure Engineer, Communications Technical Lead Rochester Institute of Technology PGP: BFAD 8461 4CCF DC95 DA2C B0EB 965B 082E 863E C912