From: Detlev Zundel Date: Fri, 25 Apr 2008 17:26:36 +0200 Subject: [U-Boot-Users] [PATCH 2/2] Add the Harris QUAD100HD AMCC 405EP-based board. In-Reply-To: <20080425144001.0cdb8f4e@peedub.jennejohn.org> (Gary Jennejohn's message of "Fri, 25 Apr 2008 14:40:01 +0200") References: <20080423151258.7ac66064@peedub.jennejohn.org> <200804240827.20526.sr@denx.de> <20080425144001.0cdb8f4e@peedub.jennejohn.org> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Gary, > On Thu, 24 Apr 2008 08:27:20 +0200 > Stefan Roese wrote: > >> > +#define CONFIG_IPADDR 192.168.1.67 >> > +#define CONFIG_SERVERIP 192.168.1.50 >> > +#define CONFIG_GATEWAYIP 192.168.1.1 >> > +#define CONFIG_NETMASK 255.255.255.0 >> > +#define CONFIG_ETHADDR 00:01:02:03:04:05 >> > +#define CONFIG_ETH1ADDR 00:01:02:03:04:06 >> >> Are you really sure that you want to provide default MAC-addresses? We usually >> don't do this. >> > > The customer had CONFIG_ETHADDR set in PPCBoot. I added CONFIG_ETH1ADDR > analog to that, since I have CONFIG_NET_MULTI defined in quad100hd.h. > > I personally don't care either way and have no problem with removing them. > Don't know what the customer would have to say about that. Mac addresses (not that those are worth of that title) should not go into stock U-Boot source. This only calls for lots of trouble as discussed n+1 times. The customer will have to assign correct addresses anyway, so there is no reason to set a bad example in source others will copy from. Cheers Detlev -- A GNU manual should give a good introduction to a beginner reading through from the start, and should also provide all the details that hackers want. --- GNU Coding Standards -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de