From: Detlev Zundel Date: Wed, 10 Jun 2009 13:39:20 +0200 Subject: [U-Boot] [PATCH v2 2/3] digsy MTC: Add SPI support. In-Reply-To: <1244549692-68089-2-git-send-email-gjb@semihalf.com> (Grzegorz Bernacki's message of "Tue, 9 Jun 2009 14:14:51 +0200") References: <1244549692-68089-1-git-send-email-gjb@semihalf.com> <1244549692-68089-2-git-send-email-gjb@semihalf.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Grzegorz, > Signed-off-by: Grzegorz Bernacki > --- > v2: > - use accessor macros > > board/digsy_mtc/digsy_mtc.c | 14 ++++++++++++++ > include/configs/digsy_mtc.h | 7 +++++++ > 2 files changed, 21 insertions(+), 0 deletions(-) [...] > +#ifdef CONFIG_MPC52XX_SPI > + /* SPI on Tmr2/3/4/5 pins */ > + setbits_be32(&gpio->port_config, (1 << 29)); Sorry for missing this on the first round, but as this is always defined we should work this into CONFIG_SYS_GPS_PORT_CONFIG in digsy_mtc.h. A comment explaining this (as far as easily possible) would also be nice. include/configs/inka4x0.h is a nice example on how to do this. Cheers Detlev -- Emacs is the way to purify your soul using garbage collection. -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu@denx.de