From: Andi Kleen Subject: Re: [PATCH 10/20] hpfs: replace BKL with a global mutex Date: Tue, 25 Jan 2011 16:15:51 -0800 Message-ID: References: <1295993854-4971-1-git-send-email-arnd@arndb.de> <1295993854-4971-11-git-send-email-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org To: linux-kernel@vger.kernel.org Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Arnd Bergmann writes: > This removes the BKL in hpfs in a rather awful > way, by replacing it with a mutex that basically > serializes the entire file system. I don't think that's a very good idea, there's danger of holding it over IO and that would be really bad (as in like MINIX[1]) It would be better to do it the i810 way and check for the number of CPUs at module init time and refuse to run if it's > 1 -Andi [1] showing my age -- Andi Kleen Intel Open Source Technology Center