Return-Path: Date: Fri, 09 Oct 2020 10:13:37 +0900 Message-ID: From: Hajime Tazaki Subject: Re: [RFC v7 06/21] scritps: um: suppress warnings if SRCARCH=um In-Reply-To: <5caf34d16a0f2816b47cd8712ca7d59e9733a815.camel@sipsolutions.net> References: <5caf34d16a0f2816b47cd8712ca7d59e9733a815.camel@sipsolutions.net> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII To: johannes@sipsolutions.net Cc: linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, tavi.purdila@gmail.com, linux-kernel-library@freelists.org, linux-arch@vger.kernel.org, retrage01@gmail.com List-ID: On Thu, 08 Oct 2020 00:24:17 +0900, Johannes Berg wrote: > > On Tue, 2020-10-06 at 18:44 +0900, Hajime Tazaki wrote: > > This commit fixes numbers of warning messages about leaked CONFIG > > options. > > No it doesn't ... it suppresses them, not a fan at all. Agree to rewrite the description. > > nommu mode of UML requires copies of kernel headers to offer > > syscall-like API for the library users. Thus, the warnings are to be > > avoided to function this exposure of API. > > I don't see that here, so maybe make that part of the patch where it > actually happens, with a big comment, Although I didn't, this patch should Cc the maintainer of ./scripts/headers_install.sh. I thought this should be as a separate one, but I can Cc (in the commit message) to the commit that actual build happens if that helps to understand. > and maybe only when actually building for NOMMU/LKL? The standalone UML doesn't use the headers_install.sh script (AFAIK), so I think this would be okay. -- Hajime