From: Detlev Zundel Date: Fri, 17 Feb 2012 16:07:53 +0100 Subject: [U-Boot] [PATCH] command, log: print with "log show" a full logbuffer In-Reply-To: <1329390141-5356-1-git-send-email-hs@denx.de> (Heiko Schocher's message of "Thu, 16 Feb 2012 12:02:21 +0100") References: <1329390141-5356-1-git-send-email-hs@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Heiko, > If the logbuffer contains LOGBUFF_LEN chars, they never got > printed with the "log show" command, because chars get > printed with the following for loop: > > for (i = 0; i < (size & LOGBUFF_MASK); i++) { > > with size = LOGBUFF_LEN and LOGBUFF_MASK = (LOGBUFF_LEN-1) > for loop never executed ... > > Fix this. > > Signed-off-by: Heiko Schocher Indeed a good catch! Acked-by: Detlev Zundel -- LISP is the most powerful programming language, and if you want an inter- preter, LISP is the best. None of the other languages come anywhere near LISP in their power. The most exciting things about LISP are read, eval, and print. If you look at other languages, they have no equivalent for any of those. -- Richard Stallman -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de