From: Detlev Zundel Date: Wed, 10 Aug 2011 22:59:52 +0200 Subject: [U-Boot] [PATCH] tsec: Configure the buffer descriptor bases to always include all of the descriptors In-Reply-To: <0F8B3F71-13E6-421A-9DAD-7790A2D54794@freescale.com> (Andy Fleming's message of "Wed, 10 Aug 2011 14:49:13 -0500") References: <1312960344-1499-1-git-send-email-joe.hershberger@ni.com> <0F8B3F71-13E6-421A-9DAD-7790A2D54794@freescale.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Andy, [...] >>> It seems the resetting of the indexes to 0 was added by Andy Fleming >>> in 063c12633d5ad74d52152d9c358e715475e17629, though the log doesn't >>> discuss it.. >> >> Yes, I see - it even slipped my review :( For the patch as such I don't >> have a preference - looking at the code both ways really read the same >> for me. > > > Well, it wasn't added in that patch, exactly. What really happened is > I accidentally applied two patches, and then had to break them up > again. That part accidentally got put in the second patch. A careful > review of the patch history indicates that the indices have always > been zeroed out beforehand (though sometimes in separate functions). It slipped my review nevertheless. > All the same, it looks like this patch is a good idea, to me. Then submit an acked-by which should help the patch along. Cheers Detlev -- F?r jemanden, der in eine Religion geboren wurde, in der das Ringen um eine einzige Seele ein Stafettenlauf ?ber viele Jahrhunderte sein kann [..], hat das Tempo des Christentums etwas Schwindelerregendes. Wenn der Hinduismus friedlich dahinflie?t wie der Ganges, dann ist das Christentum Toronto in der Rushhour. -- Yann Martel -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de