From: Detlev Zundel Date: Fri, 26 Mar 2010 10:38:11 +0100 Subject: [U-Boot] [review request] cmd_bmp.c: added standard subcommand handling In-Reply-To: <1269464698-7943-1-git-send-email-fransmeulenbroeks@gmail.com> (Frans Meulenbroeks's message of "Wed, 24 Mar 2010 22:04:58 +0100") References: <1269464698-7943-1-git-send-email-fransmeulenbroeks@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Frans, > This is not a formal patch but a review request. > Do people feel this patch is desirable and ok? I feel it is desirable yes. > and should I keep it like this, or should I merge do_bmp_info and > bmp_info into one func (and similarly for do_bmp_display and > bmp_display) I'd vote to keep the functions separate. I always prefer to keep core functionality and user interfaces separate to allow for different user interfaces. This usually also enforces clearer apis for the functions ;) Cheers Detlev -- Thanks so much for Emacs. What a wondrous system -- one of the real seven wonders of the world. Forced to choose between Emacs and, say, any pyramid, I'd take Emacs. -- Robert Boyer -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de