From: Detlev Zundel Date: Mon, 02 Nov 2009 14:46:25 +0100 Subject: [U-Boot] [PATCH] Enable port-mapped access to 16550 UART In-Reply-To: (Graeme Russ's message of "Fri, 30 Oct 2009 07:48:41 +1100") References: <1256347676-14216-1-git-send-email-graeme.russ@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Graeme, >> we at least start using the Linux convention and turn all the register >> accesses into "serial_{in,out}" and define these for X86 and !X86 like >> you did. >> >> This way should be somewhat clearer than defining a "writeb" not to be a >> writeb after all, which I find confusing. >> >> What do you think? >> > > So essentially go with my patch but rename uart_writeb to serial_out and > uart_readb to serial_in? If so, I'll re-spin Yes please. Thanks Detlev -- The fact is, volatile on data structures is a bug. It's a wart in the C language. It shouldn't be used. -- Linus Torvalds -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de