Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MslvO-0001zW-AC for qemu-devel@nongnu.org; Tue, 29 Sep 2009 19:16:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MslvJ-0001zG-Tp for qemu-devel@nongnu.org; Tue, 29 Sep 2009 19:16:02 -0400 Received: from [199.232.76.173] (port=38907 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MslvJ-0001zB-F4 for qemu-devel@nongnu.org; Tue, 29 Sep 2009 19:15:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4229) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MslvI-0001GZ-UH for qemu-devel@nongnu.org; Tue, 29 Sep 2009 19:15:57 -0400 From: Juan Quintela In-Reply-To: (Blue Swirl's message of "Wed, 23 Sep 2009 20:16:38 +0300") References: <83add4094da4dd3ddd50d849623f658e93e482c0.1253661009.git.quintela@redhat.com> <761ea48b0909230148l46b757dcwcc9d1c0d5aec9a8@mail.gmail.com> <87iqf9iqx6.fsf@pike.pond.sub.org> Date: Wed, 30 Sep 2009 01:15:43 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: [PATCH 6/7] Add -Wold-style-declaration -Wold-style-definition to QEMU_CFLAGS List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Laurent Desnogues , Markus Armbruster , qemu-devel@nongnu.org Blue Swirl wrote: > On Wed, Sep 23, 2009 at 7:09 PM, Markus Armbruster wr= ote: >> Laurent Desnogues writes: >> >>> On Wed, Sep 23, 2009 at 1:19 AM, Juan Quintela wr= ote: >>>> ANSI c89 has been with us for a while. >>>> >>>> Signed-off-by: Juan Quintela >>>> --- >>>> =C2=A0configure | =C2=A0 =C2=A01 + >>>> =C2=A01 files changed, 1 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/configure b/configure >>>> index 62dccd2..81b9ba8 100755 >>>> --- a/configure >>>> +++ b/configure >>>> @@ -1648,6 +1648,7 @@ if test "$debug" =3D "no" ; then >>>> =C2=A0fi >>>> =C2=A0QEMU_CFLAGS=3D"-Wall -Wundef -Wendif-labels -Wwrite-strings -Wmi= ssing-prototypes $QEMU_CFLAGS" >>>> =C2=A0QEMU_CFLAGS=3D"-Wstrict-prototypes -Wredundant-decls $QEMU_CFLAG= S" >>>> +QEMU_CFLAGS=3D"-Wold-style-declaration -Wold-style-definition $QEMU_C= FLAGS" >>> >>> Some older versions of gcc don't handle -Wold-style-declaration. >>> For instance gcc 4.1.2. >> >> Pretty old, do we want to support it? =C2=A0If yes, make configure detect >> whether the warning works? > > Yes, OpenBSD uses 3.3.5 (propolice). > > There are already similar checks for linker flags in configure, new > checks for warnings available would allow a different set of flags for > the latest and greatest GCC and the good old ones. Fixed in new series just sent. It detects in configure if flags exists. Thanks for the review, Juan.