Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nmp7j-0000QI-Vu for qemu-devel@nongnu.org; Wed, 03 Mar 2010 09:00:28 -0500 Received: from [199.232.76.173] (port=52619 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nmp7j-0000Pd-Bt for qemu-devel@nongnu.org; Wed, 03 Mar 2010 09:00:27 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nmp7i-0003Ed-2n for qemu-devel@nongnu.org; Wed, 03 Mar 2010 09:00:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51584) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nmp7h-0003ET-HF for qemu-devel@nongnu.org; Wed, 03 Mar 2010 09:00:25 -0500 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o23E0MNk032031 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 3 Mar 2010 09:00:24 -0500 From: Juan Quintela In-Reply-To: <4B8E6955.6030900@redhat.com> (Kevin Wolf's message of "Wed, 03 Mar 2010 14:51:17 +0100") References: <4B8E6955.6030900@redhat.com> Date: Wed, 03 Mar 2010 15:00:19 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH 06/10] vl: exit if we are not able to write into the pipe List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: amit.shah@redhat.com, qemu-devel@nongnu.org Kevin Wolf wrote: > Am 03.03.2010 13:06, schrieb Juan Quintela: >> Signed-off-by: Juan Quintela >> --- >> vl.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/vl.c b/vl.c >> index db7a178..119c7e4 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -5745,6 +5745,7 @@ int main(int argc, char **argv, char **envp) >> uint8_t status = 1; >> if (write(fds[1], &status, 1) != 1) { >> perror("daemonize. Writing to pipe\n"); >> + exit(1); >> } >> } else >> #endif > > This is already the handling code for a fatal error, it's just trying to > tell the parent process that it went wrong. Completing the context: > > fprintf(stderr, "Could not acquire pid file: %s\n", > strerror(errno)); > exit(1); > } > > So there is already an exit(1), this patch doesn't change anything. > > Kevin Else without braces :( You are right. Would remove on respin. Later, Juan.