Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NFuNT-0005GB-6U for qemu-devel@nongnu.org; Wed, 02 Dec 2009 13:56:39 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NFuNO-0005A9-LC for qemu-devel@nongnu.org; Wed, 02 Dec 2009 13:56:38 -0500 Received: from [199.232.76.173] (port=37053 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFuNO-00059o-AA for qemu-devel@nongnu.org; Wed, 02 Dec 2009 13:56:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:5927) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NFuNN-0008CW-RB for qemu-devel@nongnu.org; Wed, 02 Dec 2009 13:56:34 -0500 From: Juan Quintela In-Reply-To: <20091202183208.GE3956@redhat.com> (Michael S. Tsirkin's message of "Wed, 2 Dec 2009 20:32:08 +0200") References: <20091202145232.GF18519@redhat.com> <20091202183208.GE3956@redhat.com> Date: Wed, 02 Dec 2009 19:55:51 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH 29/41] virtio-net: in_use and first_multi only handle unsigned values List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org "Michael S. Tsirkin" wrote: > On Wed, Dec 02, 2009 at 07:30:18PM +0100, Juan Quintela wrote: >> We can change things to be int32_t if that makes more sense (they were sent >> as uint32). >> >> vmstate checks that the type of the value that you sent and the function >> that you use for sending match. In this case, it was sending a int32_t >> with the function to send uint32_t. In this particular case it didn't >> matter (value is 0/1). But vmstate don't know what cases matter/don't >> matter. It just test _always_ that you are using the right function for >> your type. >> >> If you think that it is better to change the type of the value to >> int32_t and change the functions, that is also ok with me. >> What I care is that type of function and field are the same. >> >> Later, Juan. > > int is a better type than int32 here. will switch to int (I really hope that int32_t == int in all architectures that we are interested in) > Please make the save/load functions match. > If you like, convert it to bool. bool is only 1 byte, not four. I wasn't the one using 4 bytes for a bool. Later, Juan.