Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nm1Oh-00057D-D6 for qemu-devel@nongnu.org; Mon, 01 Mar 2010 03:54:39 -0500 Received: from [199.232.76.173] (port=47688 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nm1Oh-000572-4n for qemu-devel@nongnu.org; Mon, 01 Mar 2010 03:54:39 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nm1Of-0006fD-A7 for qemu-devel@nongnu.org; Mon, 01 Mar 2010 03:54:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:5765) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nm1Oe-0006f4-Tc for qemu-devel@nongnu.org; Mon, 01 Mar 2010 03:54:37 -0500 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o218sZEN009218 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 1 Mar 2010 03:54:35 -0500 From: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH RFC 12/48] error: New error_printf() and error_vprintf() References: <1267034160-3517-1-git-send-email-armbru@redhat.com> <1267034160-3517-13-git-send-email-armbru@redhat.com> <20100226164354.6be8466d@redhat.com> Date: Mon, 01 Mar 2010 09:54:32 +0100 In-Reply-To: <20100226164354.6be8466d@redhat.com> (Luiz Capitulino's message of "Fri, 26 Feb 2010 16:43:54 -0300") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org Luiz Capitulino writes: > On Wed, 24 Feb 2010 18:55:24 +0100 > Markus Armbruster wrote: > >> FIXME They should return int, so callers can calculate width. >> >> Signed-off-by: Markus Armbruster >> --- >> qemu-error.c | 49 ++++++++++++++++++++++++++++++++++++++++++------- >> qemu-error.h | 14 ++++++++++++++ >> 2 files changed, 56 insertions(+), 7 deletions(-) >> >> diff --git a/qemu-error.c b/qemu-error.c >> index 63bcdcf..76c660a 100644 >> --- a/qemu-error.c >> +++ b/qemu-error.c >> @@ -1,18 +1,53 @@ >> +/* >> + * Error reporting >> + * >> + * Copyright (C) 2010 Red Hat Inc. >> + * >> + * Authors: >> + * Markus Armbruster , >> + * >> + * This work is licensed under the terms of the GNU GPL, version 2 or later. >> + * See the COPYING file in the top-level directory. >> + */ >> + >> #include >> #include "monitor.h" >> #include "sysemu.h" >> >> -void qemu_error(const char *fmt, ...) >> +/* >> + * Print to current monitor if we have one, else to stderr. >> + * FIXME should return int, so callers can calculate width, but that >> + * requires surgery to monitor_printf(). Left for another day. >> + */ >> +void error_vprintf(const char *fmt, va_list ap) >> { >> - va_list args; >> - >> - va_start(args, fmt); >> if (cur_mon) { >> - monitor_vprintf(cur_mon, fmt, args); >> + monitor_vprintf(cur_mon, fmt, ap); >> } else { >> - vfprintf(stderr, fmt, args); >> + vfprintf(stderr, fmt, ap); >> } >> - va_end(args); >> +} > > This can be static. Yes. But why would that be useful? It's neither a name space pollution nor does it poke a hole into an abstraction. >> + >> +/* >> + * Print to current monitor if we have one, else to stderr. >> + * FIXME just like error_vprintf() >> + */ >> +void error_printf(const char *fmt, ...) >> +{ >> + va_list ap; >> + >> + va_start(ap, fmt); >> + error_vprintf(fmt, ap); >> + va_end(ap); >> +} > > This function's name is inconsistent with qemu_error() and > qemu_error_new(). I'm fond of prepending qemu_ to random symbols left and right. Yes, I know I'm reading QEMU source code, thank you :) If the names here are really important: What about stripping qemu_ from qemu_error() & friends?