Received: from [140.186.70.92] (port=56020 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OMFyD-0002UF-Is
	for qemu-devel@nongnu.org; Wed, 09 Jun 2010 03:45:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1OMFyC-0005OH-C5
	for qemu-devel@nongnu.org; Wed, 09 Jun 2010 03:45:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:1717)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1OMFyC-0005O2-31
	for qemu-devel@nongnu.org; Wed, 09 Jun 2010 03:45:04 -0400
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans
References: <20100607150309.GA13369@redhat.com>
	<201006071716.31103.paul@codesourcery.com>
	<20100607161730.GB11177@redhat.com>
	<201006071742.56312.paul@codesourcery.com>
	<20100607174140.GE11177@redhat.com>
Date: Wed, 09 Jun 2010 09:44:51 +0200
In-Reply-To: <20100607174140.GE11177@redhat.com> (Michael S. Tsirkin's message
	of "Mon, 7 Jun 2010 20:41:40 +0300")
Message-ID: <m3631s645o.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org

"Michael S. Tsirkin" <mst@redhat.com> writes:

> On Mon, Jun 07, 2010 at 05:42:55PM +0100, Paul Brook wrote:
>> > On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote:
>> > > > With -netdev, there now seems to be little need to support vlans,
>> > > > enabling them leads to user confusion and bad performance.
>> > > > Disable support for vlans by default, add config option to enable.
>> > > 
>> > > No. If you want to remove vlans, then actually do that.
>> > 
>> > How is this not what this patch does?  You mean kill the code
>> > completely, not just --contigure option?
>> 
>> Yes. Configure options are bad. If code isn't worth enabling by default then 
>> you've got to have a very good reason why it exists at all.
>> 
>> Paul
>
> Everyone ok with disabling vlans with no config option?

Wrong question.  You got to ask "anyone *not* ok with disabling vlans
with no config option?"