Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJ8ri-00019d-Ab for qemu-devel@nongnu.org; Tue, 23 Jun 2009 12:28:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJ8rc-000165-Is for qemu-devel@nongnu.org; Tue, 23 Jun 2009 12:28:57 -0400 Received: from [199.232.76.173] (port=49286 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJ8rc-00015q-DH for qemu-devel@nongnu.org; Tue, 23 Jun 2009 12:28:52 -0400 Received: from mx2.redhat.com ([66.187.237.31]:51914) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MJ8rc-000052-0O for qemu-devel@nongnu.org; Tue, 23 Jun 2009 12:28:52 -0400 In-Reply-To: (Blue Swirl's message of "Tue\, 23 Jun 2009 19\:19\:11 +0300") References: From: Juan Quintela Date: Tue, 23 Jun 2009 18:27:25 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH 11/15] sd flash is only used in arm devices List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org Blue Swirl wrote: > On 6/23/09, quintela@redhat.com wrote: >> From: Juan Quintela > > While $SUBJECT may be true, the patch still goes to wrong direction. > The long term goal is to have a single binary for all systems. This > means that devices should get more generic and not be tied to some > systems. What do you prefer then, a config option that get only enabled for each arch when it is needed? Something like ARCH_HAS_SD=0|1 and then have the sd.o file in a single place on the Makefile. What we are searching here is to be able to compile-out functionality that we are not interested in. This RFC was related about how people preffer it implemented. Thanks for de review, Juan.