Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nm1IN-0002UV-G4 for qemu-devel@nongnu.org; Mon, 01 Mar 2010 03:48:07 -0500 Received: from [199.232.76.173] (port=60573 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nm1IN-0002UE-0T for qemu-devel@nongnu.org; Mon, 01 Mar 2010 03:48:07 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nm1IL-00066c-C9 for qemu-devel@nongnu.org; Mon, 01 Mar 2010 03:48:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47557) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nm1IK-00066Y-WB for qemu-devel@nongnu.org; Mon, 01 Mar 2010 03:48:05 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o218m3NQ004965 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 1 Mar 2010 03:48:03 -0500 From: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH RFC 11/48] error: Move qemu_error & friends into their own header References: <1267034160-3517-1-git-send-email-armbru@redhat.com> <1267034160-3517-12-git-send-email-armbru@redhat.com> <20100226164334.4c3ca52d@redhat.com> Date: Mon, 01 Mar 2010 09:48:01 +0100 In-Reply-To: <20100226164334.4c3ca52d@redhat.com> (Luiz Capitulino's message of "Fri, 26 Feb 2010 16:43:34 -0300") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org Luiz Capitulino writes: > On Wed, 24 Feb 2010 18:55:23 +0100 > Markus Armbruster wrote: > >> >> Signed-off-by: Markus Armbruster >> --- >> hw/scsi-bus.c | 2 +- >> hw/scsi-disk.c | 3 +-- >> hw/scsi-generic.c | 1 + >> hw/usb-serial.c | 1 + >> hw/virtio-net.c | 1 + >> hw/virtio-pci.c | 2 +- >> monitor.h | 1 + >> net/dump.c | 1 + >> net/socket.c | 2 +- >> net/tap-linux.c | 1 + >> net/tap.c | 1 + >> qemu-config.c | 1 + >> qemu-error.h | 12 ++++++++++++ >> qemu-tool.c | 2 +- >> qerror.c | 2 +- >> sysemu.h | 8 -------- >> 16 files changed, 26 insertions(+), 15 deletions(-) >> create mode 100644 qemu-error.h > > Minor: isn't this change related to patch 02/48? I would merge them or > move this one closer to 02. I went for minimal patches, as close to their motivation as possible. I kept these two separate, because in each of them the code motion is a bit more obvious than it would be in a merged patch. 01-02/48 are motivated by the desire to keep general error handling out of a specific customer, the monitor. I could move it down some, say between 9/48 and 10/48. 11/48 is motivated by the desire not to further pollute sysemu.h with the new error stuff, which starts in 12/48. I could squash it into 02/48. I like it the way it is well enough, but I'm not particular about it, so if you really prefer one of the above moves or squashes, let me know.