Received: from [140.186.70.92] (port=51660 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PAPpE-0001ha-46 for qemu-devel@nongnu.org; Mon, 25 Oct 2010 12:23:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PAPoO-0006HO-46 for qemu-devel@nongnu.org; Mon, 25 Oct 2010 12:22:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27072) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PAPoN-0006HI-U5 for qemu-devel@nongnu.org; Mon, 25 Oct 2010 12:22:16 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o9PGMEXV011438 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 25 Oct 2010 12:22:15 -0400 From: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH] initialize unit id of IDE bus References: <20101024162315.GG2343@redhat.com> <20101025154236.GH2343@redhat.com> Date: Mon, 25 Oct 2010 18:22:12 +0200 In-Reply-To: <20101025154236.GH2343@redhat.com> (Gleb Natapov's message of "Mon, 25 Oct 2010 17:42:36 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: qemu-devel@nongnu.org Gleb Natapov writes: > On Mon, Oct 25, 2010 at 04:29:35PM +0200, Markus Armbruster wrote: >> Gleb Natapov writes: >> >> > Without this patch both buses on PIIX3_IDE device have the same unit id. >> >> Are you sure that's wrong? >> > So how do I know which bus is it on PIIX3_IDE? [...] Let me try to explain the IDE pointer thicket. piix3-ide provides two IDE buses. pci_piix_ide_initfn() stores them in PCIIDEState member IDEBus bus[2]. Technically redundant, because qdev stores child buses in dev.qdev.child_bus. IDEBus points back: qbus.parent. Up to two IDE devices can sit on each IDE bus. The first one uses IDEBus members master and ifs[0], the second one uses slave and ifs[1]. ifs[i].bus points back to the IDE bus. {master,slave}.qdev.parent_bus point back to the IDE bus. Say you got an IDEDevice and want to know which to which of the two buses it's connected. Let's call it d. d->qdev.parent_bus is the BusState. Upcast to IDEBus: b = DO_UPCAST(IDEBus, qbus, d->qdev.parent_bus). b->qbus.parent is the IDE controller. Upcast to PCIIDEState: c = DO_UPCAST(PCIIDEState, dev, n->qbus.parent); If c->bus[0] == b, it's on the first bus. Else it must be on the second bus, i.e. c->bus[1] == b. Hope I didn't screw this up too badly.