Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mlnd4-0001I2-R8 for qemu-devel@nongnu.org; Thu, 10 Sep 2009 13:40:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mlnd1-0001C0-0x for qemu-devel@nongnu.org; Thu, 10 Sep 2009 13:40:18 -0400 Received: from [199.232.76.173] (port=36922 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mlnd0-0001Bf-IF for qemu-devel@nongnu.org; Thu, 10 Sep 2009 13:40:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41990) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mlnd0-00023T-4w for qemu-devel@nongnu.org; Thu, 10 Sep 2009 13:40:14 -0400 From: Juan Quintela In-Reply-To: (malc's message of "Thu, 10 Sep 2009 21:02:01 +0400 (MSD)") References: Date: Thu, 10 Sep 2009 19:39:57 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH 05/26] Unexport ticks_per_sec variable. Create get_ticks_per_sec() function List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: qemu-devel@nongnu.org malc wrote: > On Thu, 10 Sep 2009, Juan Quintela wrote: > >> malc wrote: >> > On Thu, 10 Sep 2009, Juan Quintela wrote: >> > >> >> malc wrote: >> >> > On Thu, 10 Sep 2009, Juan Quintela wrote: >> >> > >> >> > Point being? >> >> > >> >> > [..snip..] >> >> >> >> See next patch. We need to put the variable in one struct, we don't >> >> want to change everything to read the variable from the struct. >> > >> > So put the in the _pre vmstate callback (or whatever it's called). >> > >> >> >> >> And at some point code, timer code have to move to qemu-timer.c code, >> >> not in vl.c. >> > >> > So? >> >> What is the problem with this approach? > > My problem with this patch is that it is completely pointless, Don't agree. > touches a gob of places Right, it happens each time that you changes an API, nothing new to see here. > and the fact that you apparently never seen what a > function call entails on PPC64 (any ABI). Obviously I am not a expert on function calls, but if an architecture is limiting the number of functions you can call -> Darwin will do his job. > > [..snip..] > >> My goal is having less global variables/state not more. And your point >> to have it as it is today? > > Yes, if it aint broke don't fix it. Obviously, I can't disagree more with you. Modularity, encapsulaption and _make sure_ that nobody can change this variable becaues it is _not_ a variable are alien concepts here. Later, Juan.