Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NXtf7-0005rQ-06 for qemu-devel@nongnu.org; Thu, 21 Jan 2010 04:49:13 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NXtf2-0005oA-KH for qemu-devel@nongnu.org; Thu, 21 Jan 2010 04:49:12 -0500 Received: from [199.232.76.173] (port=57567 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NXtf2-0005nu-DS for qemu-devel@nongnu.org; Thu, 21 Jan 2010 04:49:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55783) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NXtf1-0006eC-DH for qemu-devel@nongnu.org; Thu, 21 Jan 2010 04:49:07 -0500 From: Juan Quintela In-Reply-To: <20100121084406.GA3644@bee.dooz.org> (=?utf-8?Q?=22Lo=C3=AFc?= Minier"'s message of "Thu, 21 Jan 2010 09:44:06 +0100") References: <20100119101119.GA11358@bee.dooz.org> <20100119114750.GB11613@bee.dooz.org> <20100120113741.GA31679@pig.zood.org> <20100120134940.GA547@pig.zood.org> <20100120165103.GA3303@pig.zood.org> <20100121084406.GA3644@bee.dooz.org> Date: Thu, 21 Jan 2010 10:48:54 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: Stop using "which" in ./configure List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?Q?Lo=C3=AFc?= Minier Cc: qemu-devel@nongnu.org Lo=C3=AFc Minier wrote: > On Wed, Jan 20, 2010, M=C3=A5ns Rullg=C3=A5rd wrote: >> If you make that IFS=3D${local_ifs:-$(printf ' \t\n')} it should be safe. >> Likewise if you set the value first. > > Ok; see attached patches I still think that path_of is a complication that we don't really need. "type" command exist in posix, and althought its output is not defined, if the output of a real command don't show the path that we need (in this case /usr/bin/install), then type is pretty wrong in my humble opinion. With respect of the rest of the patch. Only real difference is that mine uses "prog_exists" vs yours use "has" name. I obviosly think that prog_exists is a more descriptive name, but I really don't care one way or another. Can we agree that we don't need path_of, and then just stop playing with IFS and friends? Later, Juan.