From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <4B574E13.2010102@mail.berlios.de> (Stefan Weil's message of
	"Wed, 20 Jan 2010 19:40:19 +0100")
References: <cover.1264008180.git.quintela@redhat.com>
	<f95b339dffed5629c1cbd0baf8afc134f7f9124b.1264008180.git.quintela@redhat.com>
	<4B574E13.2010102@mail.berlios.de>
Date: Wed, 20 Jan 2010 19:52:30 +0100
Message-ID: <m3bpgo6235.fsf@neno.neno>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH 1/5] substitute all uses of which by type
To: Stefan Weil <weil@mail.berlios.de>
Cc: qemu-devel@nongnu.org

Stefan Weil <weil@mail.berlios.de> wrote:
> Juan Quintela schrieb:
>> Except in one case, we are only interested in knowing if a command
>> exist, not is path. Just create prog_exists() function that does this
>> check.
>>
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>
> See comments below. The changes proposed are a suggestion, no real need.
>
> Regards,
> Stefan
>
>> ---
>> configure | 25 ++++++++++++++-----------
>> 1 files changed, 14 insertions(+), 11 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 5631bbb..71edaf5 100755
>> --- a/configure
>> +++ b/configure
>> @@ -27,6 +27,11 @@ compile_prog() {
>> $cc $QEMU_CFLAGS $local_cflags -o $TMPE $TMPC $LDFLAGS $local_ldflags
>> > /dev/null 2> /dev/null
>> }
>>
>> +prog_exist() {
>> + prog="$1"
>> + type $prog > /dev/null 2> /dev/null
>
> I personally prefer
> + type $prog >/dev/null 2>&1
> because it is shorter (no whitespace after >, no duplicate /dev/null).
> Currently, all variants to write this pattern are used.
> Maybe we can reduce this.

Agreed.  For next series if there is not needed a rebase.

Later, Juan.