Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MUmRu-0000yx-Bv for qemu-devel@nongnu.org; Sat, 25 Jul 2009 14:58:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MUmRq-0000yY-Tk for qemu-devel@nongnu.org; Sat, 25 Jul 2009 14:58:26 -0400 Received: from [199.232.76.173] (port=43979 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MUmRq-0000yV-Oj for qemu-devel@nongnu.org; Sat, 25 Jul 2009 14:58:22 -0400 In-Reply-To: (malc's message of "Sat\, 25 Jul 2009 19\:13\:18 +0400 \(MSD\)") References: <4A6B0E6E.6030600@gnu.org> From: Juan Quintela Date: Sat, 25 Jul 2009 20:57:57 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH 45/46] Remove AUDIO_DRIVERS define List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: Paolo Bonzini , aliguori@us.ibm.com, qemu-devel@nongnu.org malc wrote: > On Sat, 25 Jul 2009, Paolo Bonzini wrote: > >> On 07/25/2009 01:13 PM, malc wrote: >> > On Fri, 24 Jul 2009, Juan Quintela wrote: >> > >> > > Signed-off-by: Juan Quintela >> > > --- >> > > audio/audio.c | 25 ++++++++++++++++++++++++- >> > > configure | 3 --- >> > > 2 files changed, 24 insertions(+), 4 deletions(-) >> > >> > That's how it used to be before, i see no reason of going back to this >> > style. >> >> Personally I prefer Juan's. It makes things more uniform; even though for >> example I disagree on changing autoconfy HAVE_* defines to CONFIG_*, it >> wouldn't be a problem at all to have CONFIG_* in qemu. > > For starters this is not a functional equivalent of the things currently > in place, please read the commit message of: 0c58ac1c7 Thanks very much for the review. I understand now why it was done the way it is, searching for a solution. Will try to think a better way of being able to autogenerate config-host.h and maintaining the functionality of AUDIO_DRIVERS. Later, Juan.