Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MM4SN-0006UC-LE for qemu-devel@nongnu.org; Wed, 01 Jul 2009 14:22:55 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MM4SI-0006Tm-OZ for qemu-devel@nongnu.org; Wed, 01 Jul 2009 14:22:54 -0400 Received: from [199.232.76.173] (port=42137 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MM4SI-0006Tj-Jq for qemu-devel@nongnu.org; Wed, 01 Jul 2009 14:22:50 -0400 Received: from mx2.redhat.com ([66.187.237.31]:53671) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MM4SI-0008FY-4e for qemu-devel@nongnu.org; Wed, 01 Jul 2009 14:22:50 -0400 In-Reply-To: (Blue Swirl's message of "Wed\, 1 Jul 2009 21\:01\:29 +0300") References: <3d7905b5538d8d8787c8de4ae0486b849063e4cd.1246466962.git.quintela@redhat.com> From: Juan Quintela Date: Wed, 01 Jul 2009 20:21:12 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH 09/13] TARGET_ARCH2 is already known at configure time and it is called target_cpu Remove re-construction in Makefile.target List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org Blue Swirl wrote: > On 7/1/09, quintela@redhat.com wrote: >> From: Juan Quintela >> > > TARGET_CPU would be a misleading name. TARGET_ARCH2 means that it's a > kind of subarchitecture. TARGET_SUBARCH or TARGET_ABI32_NAME should be > OK too. > > For example, there is no CPU type (or even class of CPUs) called > sparc32plus. There is Sparc (a.k.a. Sparc32, V8) and Sparc64 (a.k.a. > Ultrasparc, V9, V9plusa etc.). Sparc32plus is a userland mode for > Sparc64 CPUs where the address space is limited to 32 bits. The same > probably applies to other 32 bit subarchitectures. I agree, but I just used the same name than in configure: case "$target_cpu" in .... sparc32plus) .... esac. I don't matter the name, but we have just now: ARCH cpu TARGET_ARCH TARGET_ARCH2 TARGET_BASE_ARCH target_cpu TARGET_ABI_DIR and I am not sure that I have all of them here. target_cpu and TARGET_ARCH2 always had the same value, but perhaps changing it to TARGET_SUBARCH is a good idea. The we would end: TARGET_BASE_ARCH: architecture name (mips, sparc, ppc) TARGET_ARCH: Actual architecture TARGET_SUBARCH: change about TARGET_ARCH (sparc32plus, little/big endian variants) (was TARGET_ARCH2 and target_cpu) TARGET_ABI: call ABI for this TARGET_SUBARCH cpu = canonical name for the cpu, not sure how to relate this one with ARCH ARCH: where are we building, it is always the same than 'cpu' on configure, it is only used on the Makefiles, but I would preffer to only use one name for the same meaning. kill also cpu in configure script? Anyone with a good idea? Later, Juan.