Received: from [140.186.70.92] (port=35540 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OSWlH-0005i6-Ol for qemu-devel@nongnu.org; Sat, 26 Jun 2010 10:53:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OSWlF-0000iJ-OF for qemu-devel@nongnu.org; Sat, 26 Jun 2010 10:53:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24090) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OSWlF-0000i9-GY for qemu-devel@nongnu.org; Sat, 26 Jun 2010 10:53:37 -0400 From: Markus Armbruster Subject: Re: [Qemu-devel] Re: [PATCH 08/12] block: Catch attempt to attach multiple devices to a blockdev References: <1277484812-22012-1-git-send-email-armbru@redhat.com> <1277484812-22012-9-git-send-email-armbru@redhat.com> <20100626101146.GC27699@lst.de> Date: Sat, 26 Jun 2010 16:44:11 +0200 In-Reply-To: <20100626101146.GC27699@lst.de> (Christoph Hellwig's message of "Sat, 26 Jun 2010 12:11:46 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: kwolf@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com Christoph Hellwig writes: > On Fri, Jun 25, 2010 at 06:53:28PM +0200, Markus Armbruster wrote: >> For instance, -device scsi-disk,drive=foo -device scsi-disk,drive=foo >> happily creates two SCSI disks connected to the same block device. >> It's all downhill from there. > > And from some quick testing a while ago the thing seems to actually > work. Not that I think that it is a good idea, but do we want to change > behaviour in that respect? Valid question. I'd answer yes. It's an easy error to make, and likely to end in massive file system corruption in the guest. >> Device usb-storage deliberately attaches twice to the same blockdev, >> which fails with the fix in place. Detach before the second attach >> there. > > Can anyone explain what the hell usb storage is actually trying to do > with the two drives? It's actually a SCSI controller with a single drive on its single bus. -device usb-storage,drive=foo creates *two* devices: usb-storage itself, which serves as SCSI controller, and scsi-disk for the drive. usb-storage copies its drive property to scsi-disk. I don't like this. Each -device should create just one device.