Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NIJ4z-0003zV-Ud for qemu-devel@nongnu.org; Wed, 09 Dec 2009 04:43:29 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NIJ4v-0003yM-0V for qemu-devel@nongnu.org; Wed, 09 Dec 2009 04:43:29 -0500 Received: from [199.232.76.173] (port=51011 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NIJ4u-0003yJ-UE for qemu-devel@nongnu.org; Wed, 09 Dec 2009 04:43:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49090) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NIJ4u-0002Ui-Ej for qemu-devel@nongnu.org; Wed, 09 Dec 2009 04:43:24 -0500 From: Markus Armbruster Subject: Re: [Qemu-devel] [FOR 0.12 PATCH] qdev: Replace device names containing whitespace References: <4B1F6DCE.9090603@collabora.co.uk> Date: Wed, 09 Dec 2009 10:43:18 +0100 In-Reply-To: <4B1F6DCE.9090603@collabora.co.uk> (Ian Molton's message of "Wed, 09 Dec 2009 09:28:46 +0000") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian Molton Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org, Gerd Hoffmann Ian Molton writes: > Markus Armbruster wrote: > >> The place for verbose device names is DeviceInfo member desc. The >> name should be short & sweet. > > Agreed, however... > > Why do these (maybe others) get caps in their names? they dont look > right to me, compared to the others with nice names like usb-serial, > piix-ide, or cirrus-vga. > >> - sysbus_register_dev("Uni-north main", sizeof(UNINState), >> + sysbus_register_dev("Uni-north-main", sizeof(UNINState), >> pci_unin_main_init_device); >> pci_qdev_register(&unin_main_pci_host_info); >> - sysbus_register_dev("DEC 21154", sizeof(UNINState), >> + sysbus_register_dev("DEC-21154", sizeof(UNINState), >> pci_dec_21154_init_device); >> pci_qdev_register(&dec_21154_pci_host_info); >> - sysbus_register_dev("Uni-north AGP", sizeof(UNINState), >> + sysbus_register_dev("Uni-north-AGP", sizeof(UNINState), >> pci_unin_agp_init_device); >> pci_qdev_register(&unin_agp_pci_host_info); >> - sysbus_register_dev("Uni-north internal", sizeof(UNINState), >> + sysbus_register_dev("Uni-north-internal", sizeof(UNINState), >> pci_unin_internal_init_device); >> pci_qdev_register(&unin_internal_pci_host_info); >> } I can downcase them. Blue Swirl, any objections?