Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NFm6L-0003eC-9h for qemu-devel@nongnu.org; Wed, 02 Dec 2009 05:06:25 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NFm6G-0003cb-F9 for qemu-devel@nongnu.org; Wed, 02 Dec 2009 05:06:24 -0500 Received: from [199.232.76.173] (port=38348 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFm6G-0003cR-9k for qemu-devel@nongnu.org; Wed, 02 Dec 2009 05:06:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:16401) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NFm6F-0002Mk-UO for qemu-devel@nongnu.org; Wed, 02 Dec 2009 05:06:20 -0500 From: Juan Quintela In-Reply-To: <4B15A8FA.5080804@web.de> (Jan Kiszka's message of "Wed, 02 Dec 2009 00:38:34 +0100") References: <4B15A8FA.5080804@web.de> Date: Wed, 02 Dec 2009 11:05:33 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH] vmstate: Avoid seeking List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , qemu-devel , Liran Schour , Pierre Riteau Jan Kiszka wrote: > Seeking on vmstate save/load does not work if the underlying file is a > stream. We could try to make all QEMUFile* forward-seek-aware, but first > attempts in this direction indicated that it's saner to convert the few > qemu_fseek-on-vmstates users to plain reads/writes. > > This fixes various subtle vmstate corruptions where unused fields were > involved. > > Signed-off-by: Jan Kiszka Something changed lately. This used to work, and I also waste^spend yesterday trying to understand why it was failing to me. I am splitting the patch in virtio-net and savevm parts. (In my tree virtio-net don't use fseek anymore). Thanks for finding the bug. Later, Juan.